Open iceBear67 opened 2 years ago
We will need to handle creative item actions due to minecraft feature. Players in creative mode sends itemstack data from their client, which overrides server-side item even though it has pdc or sth else.
I ve heard something from paper-dev. They said the limitation isnt too small
I will try it later
Internal Exception: net.minecraft.network.PacketEncoder$PacketTooLargeException: PacketTooLarge - PacketPlayOutSetSlot is 5000438. Max is 2097152
And that means we can store ~2M data in one pdc, that's fully enough for many situations.
We will not work on this for this moment.
To reduce meaningless bandwidth overheads caused by #42 (with PDC), PDC Filter is set.
Patch
By redefine.
At
FriendlyByteBuf
(Paper, calledPacketDataSerializer
in spigot)Inserting hooks before
this.writeNbt(nbttagcompound)
would work, however it is leading to full of asm codes.Tasks
So here're our tasks:
Other
This feature is an option and disabled by default.