search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.11k stars 5.31k forks source link

utt2spk is copied twice in augment_data_dir.py #2995

Open thefacetakt opened 5 years ago

thefacetakt commented 5 years ago

https://github.com/kaldi-asr/kaldi/blob/master/egs/wsj/s5/steps/data/augment_data_dir.py#L191 and https://github.com/kaldi-asr/kaldi/blob/master/egs/wsj/s5/steps/data/augment_data_dir.py#L187

Perhaps, spk2utt should be copied instead?

david-ryan-snyder commented 5 years ago

Yes, it's a mistake to copy it twice, but it's harmless.

You don't need to copy the spk2utt file. It gets generated from the utt2spk file after utils/fix_data_dir.sh is called.

If you want, you could make a pull request removing line 187, but it's probably not worth the effort (I could just remove it later).

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed by a bot strictly because of inactivity. This does not mean that we think that this issue is not important! If you believe it has been closed hastily, add a comment to the issue and mention @kkm000, and I'll gladly reopen it.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.