search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.12k stars 5.31k forks source link

chime6: train_diarizer.sh: missing local/make_voxceleb1_v2.pl #4010

Open boeddeker opened 4 years ago

boeddeker commented 4 years ago

In the file kaldi/egs/chime6/s5_track2/local/train_diarizer.sh the comments suggest to use local/make_voxceleb1_v2.pl when voxceleb was downloaded recently.

https://github.com/kaldi-asr/kaldi/blob/b1d809386c17a9630d786b8fb0f67ed3bc173811/egs/chime6/s5_track2/local/train_diarizer.sh#L44-L45

The problem is, that this file does not exist in chime6.

I found this file 3 times in this repr. One symlink and two files.

.../kaldi $ find -iname "make_voxceleb1_v2.pl"
./egs/dihard_2018/v2/local/make_voxceleb1_v2.pl
./egs/dihard_2018/v1/local/make_voxceleb1_v2.pl
./egs/voxceleb/v1/local/make_voxceleb1_v2.pl
.../kaldi $ ll ./egs/dihard_2018/v2/local/make_voxceleb1_v2.pl
lrwxrwxrwx 1 cbj cbj 35 Jan 28 14:42 ./egs/dihard_2018/v2/local/make_voxceleb1_v2.pl -> ../../v1/local/make_voxceleb1_v2.pl*
.../kaldi $ ll ./egs/dihard_2018/v1/local/make_voxceleb1_v2.pl
-rwxrwxr-x 1 cbj cbj 4,5K Jan 28 14:42 ./egs/dihard_2018/v1/local/make_voxceleb1_v2.pl*
.../kaldi $ ll ./egs/voxceleb/v1/local/make_voxceleb1_v2.pl
-rwxrwxr-x 1 cbj cbj 4,6K Jan 28 14:42 ./egs/voxceleb/v1/local/make_voxceleb1_v2.pl*

After comparing the files, I think the files in dihard_2018 have a bug, because voxceleb has one bugfix commit that was not applied to dihard_2018.

Also the other make_voxceleb* files are copies. Wouldn't it be better to use symlinks?

I am not sure, who is responsible for this, maybe @aarora8, @desh2608 or @sw005320.

desh2608 commented 4 years ago

Using egs/voxceleb/v1/local/make_voxceleb1_v2.pl should work. As for whether symlinks should be used for this instead of copying over the file to local, @david-ryan-snyder is better suited to make that decision.

desh2608 commented 4 years ago

@boeddeker I have created a PR to fix this. I copied over the scripts instead of soft links because I think the Kaldi convention is that the scripts within local for an egs should be self-contained.

boeddeker commented 4 years ago

Thanks for the PR. I thought that in this case it would be better to make softlinks, because it is difficult to keep copy identical.

jtrmal commented 4 years ago

still unresolved?

desh2608 commented 4 years ago

I think the PR https://github.com/kaldi-asr/kaldi/pull/4012 can be merged, which would resolve this issue.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.