search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.11k stars 5.31k forks source link

Add support for installing OpenFST bin tools when using CMake #4263

Open asalarian opened 4 years ago

asalarian commented 4 years ago

Currently the default make based installer, compiles and installs the OpenFST bin tools (e.g. fstcompile). However, the CMake based installer only compiles and installs the fst library. It would be great to add a switch to the CMake installer to allow installing these tools as well.

danpovey commented 4 years ago

But that's already done in tools/, which we'd run regardless of build type. So we'd need a switch there too, to avoid duplicate versions of the binaries.

On Wed, Sep 9, 2020 at 6:55 PM Arash Salarian notifications@github.com wrote:

Currently the default make based installer, compiles and installs the OpenFST bin tools (e.g. fstcompile). However, the CMake based installer only compiles and installs the fst library. It would be great to add a switch to the CMake installer to allow installing these tools as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZFLOZVIO7TY7IIMCC6FJDSE5NJBANCNFSM4RB4RBXA .

asalarian commented 4 years ago

But that's already done in tools/, which we'd run regardless of build type.

The way I understand it, the CMake build system does not use the scripts in tools/.

danpovey commented 4 years ago

Yes but if you actually want to use Kaldi you should probably run those scripts anyway, as they install various things that are needed for the example scripts to run.

On Wed, Sep 9, 2020 at 7:44 PM Arash Salarian notifications@github.com wrote:

But that's already done in tools/, which we'd run regardless of build type.

The way I understand it, the CMake build system does not use the scripts in tool.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4263#issuecomment-689507333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZFLO2X62LJ4VQ7WNTVXI3SE5TARANCNFSM4RB4RBXA .

asalarian commented 4 years ago

You are right as the CMake build system is still a work in progress so it might take some time before we have all features of Kaldi in it. However, in this case OpenFST already has support for building under CMake so the needed change on Kaldi side to support building and installing the bin tools of OpenFST in CMake is a simpler task.

danpovey commented 4 years ago

Yes, we might need to change the paths e.g. in tools/common_path.sh. Unfortunately I dont have time to do this right now. Maybe someone else might.

On Wed, Sep 9, 2020 at 11:33 PM Arash Salarian notifications@github.com wrote:

You are right as the CMake build system is still a work in progress so it might take some time before we have all features of Kaldi in it. However, in this case OpenFST already has support for building under CMake so the needed change on Kaldi side to support building and installing the bin tools of OpenFST in CMake is a simpler task.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4263#issuecomment-689641149, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZFLO76POJL5E5WKTSJLK3SE6N4XANCNFSM4RB4RBXA .