search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.11k stars 5.31k forks source link

Small logic error in wsj/s5/local/chain2/tuning/run_tdnn_1i.sh #4450

Closed huntingriver closed 3 years ago

huntingriver commented 3 years ago

https://github.com/kaldi-asr/kaldi/blob/3eea37dd09b55064e6362216f7e9a60641f29f09/egs/wsj/s5/local/chain2/tuning/run_tdnn_1i.sh#L242-L246 @songmeixu Line 242 is missing "!", eg if file NOT exists, then copy. It should be: if [ ! -f $dir/init/default_trans.mdl ]; then

danpovey commented 3 years ago

mm can you please make a PR with a fix? I believe this may have been fixed in other chain2 example scripts.

huntingriver commented 3 years ago

Indeed. This is fixed in babel and swbd. I've created the PR for wsj: https://github.com/kaldi-asr/kaldi/pull/4452

csukuangfj commented 3 years ago

Closing via #4452