search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.32k stars 5.33k forks source link

Openfst 1.8.1 #4533

Open francisr opened 3 years ago

francisr commented 3 years ago

Hi,

Is there anything blocking the use of openfst 1.8.1? I have an application that relies on that version (it's the latest), but Kaldi is still using 1.7.2, and mixing openfst versions can be quite a pain.

jtrmal commented 3 years ago

Nothing in particular -- feel free to try/test it and submit a PR. You might need to bump up the C++ version y.

On Mon, May 17, 2021 at 12:00 PM Rémi Francis @.***> wrote:

Hi,

Is there anything blocking the use of openfst 1.8.1? I have an application that relies on that version (it's the latest), but Kaldi is still using 1.7.2, and mixing openfst versions can be quite a pain.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4533, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX43P5FPZ5DZEQZQQTLTOE4STANCNFSM45AX4HHQ .

kkm000 commented 3 years ago

There has been a PR open for a while and sitting on my list: #4096. It's been there for far too long a time to probably become moot. I think it's time to simply drop it: if OpenFST has broken their interface between 3rd point, "patch", releases (dunno exactly when; 1.7.2 and 1.7.7 are certainly incompatible), it's probably past the point for us to attempt supporting both, IMO. Let's just advance to the new API. I'd really appreciate it if you can make a PR, and we then declare 1.7.x for x somewhere between 3 and 7 inclusive too old to support.

As an aside, we're C++14 now.

@jtrmal, @danpovey, are we on the same page?

danpovey commented 3 years ago

Sure.

On Sat, May 22, 2021 at 4:10 AM kkm000 @.***> wrote:

There has been a PR open for a while and sitting on my list: #4096 https://github.com/kaldi-asr/kaldi/pull/4096. It's been there for far too long a time to probably become moot. I think it's time to simply drop it: if OpenFST has broken their interface between 3rd point, "patch", releases (dunno exactly when; 1.7.2 and 1.7.7 are certainly incompatible), it's probably past the point for us to attempt supporting both, IMO. Let's just advance to the new API. I'd really appreciate it if you can make a PR, and we then declare 1.7.x for x somewhere between 3 and 7 inclusive too old to support.

As an aside, we're C++14 now.

@jtrmal https://github.com/jtrmal, @danpovey https://github.com/danpovey, are we on the same page?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4533#issuecomment-846226502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZFLO4F7AISGSRZB7BOFZDTO243HANCNFSM45AX4HHQ .