search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.24k stars 5.32k forks source link

Kick portaudio install out of the main makefile #4654

Closed kkm000 closed 2 years ago

kkm000 commented 2 years ago

We already have tools/extras/install_portaudio.sh.

If you need portaudio, install portaudio. Make dependencies are so messed up that portaudio is a dependency of lmbin. This makes no sense.

jtrmal commented 2 years ago

+1 I agree

stale[bot] commented 2 years ago

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

Talos878 commented 2 years ago

On Ubuntu 20 and mac I have not been able to install without portaudio. Possibly it is still in there for this reason

danpovey commented 2 years ago

That may be because of Makefile issues. I don't think we really need portaudio.

jtrmal commented 2 years ago

could you send some detail about the setup/kaldi version? Plus the compile/configure output? I just tested in mac and there wasn't any need for portaudio y.

On Tue, Dec 28, 2021 at 5:24 PM Talos878 @.***> wrote:

On Ubuntu 20 and mac I have not been able to install without portaudio. Possibly it is still in there for this reason

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4654#issuecomment-1002183526, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYXYRAOXAJZZ3WGMAQLDUTHQEVANCNFSM5G5YRCPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

kkm000 commented 2 years ago

I am closing this issue for now. If you believe that your issue has not been addressed, please feel free to ping me, and I'll reopen it. @-mention me for a faster response!