search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.25k stars 5.32k forks source link

Introduce determinize_max_active option to control determinization delay #4742

Closed nshmyrev closed 2 years ago

nshmyrev commented 2 years ago

In times of uncertainty determinization takes too much time. We try to skip update step if there are too many tokens. Relevant discussion on kaldi-help is https://groups.google.com/g/kaldi-help/c/JtMJ8-XGjGs

danpovey commented 2 years ago

If this option was there originally, are there any notes anywhere about why it was removed?

nshmyrev commented 2 years ago

It was introduced here:

https://github.com/kaldi-asr/kaldi/pull/3737/commits/228d8a27dd2be5e73a0db70341b804cd4cce4f2d

and removed here:

https://github.com/danpovey/kaldi/commit/6836282f5285cddbc6a8c806910fb93826c2857f

I suppose it was an accident removal

jtrmal commented 2 years ago

I would merge, if Dan doesn't object?

danpovey commented 2 years ago

OK with me.

jtrmal commented 2 years ago

thanks @nshmyrev !