kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.25k stars 5.32k forks source link

fix: Fix creation of vocab_autogen_our.{1} when using 1 job #4746

Closed Agrover112 closed 2 years ago

Agrover112 commented 2 years ago

When creating the lexicon using prepare_dict.sh when my njobs=1 , the auto_vocab_splits @ Line 75 causes it to be named as $g2p_dir/"vocab_autogen_our.{1} when we want it to be named as vocab_autogen_our.1

jtrmal commented 2 years ago

Looks great, thanks! I will merge as soon as travis finishes.

jtrmal commented 2 years ago

yeah, exactly that y.

On Wed, May 25, 2022 at 11:57 AM Agrover112 @.***> wrote:

@.**** commented on this pull request.

In egs/librispeech/s5/local/prepare_dict.sh https://github.com/kaldi-asr/kaldi/pull/4746#discussion_r881828748:

@@ -77,7 +77,7 @@ if [ $stage -le 1 ]; then else auto_vocab_splits=$(eval "echo $auto_vocab_prefix.{$(seq -s',' $nj | sed 's/,$//')}") #Create the list of files to split fi

  • awk 'NR==FNR{a[$1] = 1; next} !($1 in a)' $cmudict_plain $vocab |\
  • awk 'NR==FNR{a[$1] = 1; next} !($1 in a)' $cmudict_plain $vocab |\

I hope this is what you meant?

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/pull/4746#pullrequestreview-985078196, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX4GZCHHO2M6EEWPJZTVLZEWJANCNFSM5WVPPCSQ . You are receiving this because you commented.Message ID: @.***>