search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.12k stars 5.31k forks source link

Fix Windows build - Add cctype import to kaldi-utils.cc, remove mkl_intel_c.lib #4761

Closed Zohan closed 2 years ago

Zohan commented 2 years ago

Hello again! I was able to get a successful build in VS2019, and online-gmm-decode-faster.exe running in Powershell successfully. Not too much to report, mkl_intel_c.lib is no longer a thing. Let me know if I need to do an IFDEF and check for Win32 on the cctype import. Thanks!

ochaheaven commented 2 years ago

Hi @Zohan, I have made the same modification as you to kaldi-utils.cc in #4757, so there are multiple cctype includes. It would be better to remove one of them.

jtrmal commented 2 years ago

Hi @Zohan, thanks for your contributuion, could you verify that your changes w.r.t. cctype.h are still needed even for the latest version of Kaldi? I would merge afterward.

Zohan commented 2 years ago

Hi @Zohan, thanks for your contributuion, could you verify that your changes w.r.t. cctype.h are still needed even for the latest version of Kaldi? I would merge afterward.

Have done so and confirmed there was a double import on <cctype>. I've removed my kaldi-utils.cc changes. Thanks @masa-mitsu for pointing that out.

jtrmal commented 2 years ago

Perfect, thank you very much!