search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.25k stars 5.32k forks source link

extras/srilm.sh wont build on MacOS #4762

Closed sidgupta234 closed 2 years ago

sidgupta234 commented 2 years ago

MacOS config: Darwin Darwin Kernel Version 21.5.0 root:xnu-8020.121.3~4/RELEASE_ARM64_T8101 arm64 arm While attempting to run extras/install_srilm.sh, am getting the following error message:

 MACHINE_TYPE=macosx OPTION= MAKE_PIC= release-programs) || exit 1; \
    done
make[2]: Nothing to be done for `release-programs'.
make[2]: Nothing to be done for `release-programs'.
c++ -Wall -Wno-unused-variable -Wno-uninitialized -Wno-overloaded-virtual -DINSTANTIATE_TEMPLATES  -DHAVE_LIBLBFGS -I/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/include -I/usr/include -I. -I../../include -DHAVE_ZOPEN  -L/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -Wl,-rpath -Wl,/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -u _matherr -L../../lib/macosx -L/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -Wl,-rpath -Wl,/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/  -g -O2 -fno-common -o ../bin/macosx/ngram ../obj/macosx/ngram.o ../obj/macosx/liboolm.a  ../../lib/macosx/libflm.a ../../lib/macosx/libdstruct.a ../../lib/macosx/libmisc.a ../../lib/macosx/libz.a -L/usr/lib -ltcl -lm -llbfgs -liconv 2>&1 | c++filt
ld: library not found for -llbfgs
clang: error: linker command failed with exit code 1 (use -v to see invocation)
test -f ../bin/macosx/ngram
make[2]: *** [../bin/macosx/ngram] Error 1
make[1]: *** [release-programs] Error 1
make: *** [World] Error 2
jtrmal commented 2 years ago

there was probably some error installing libBFGS... try to run extras/install_liblbfgs.sh (being in tools/) and watch for errors y.

On Fri, Jul 1, 2022 at 8:39 AM Siddharth Gupta @.***> wrote:

MacOS config: Darwin Darwin Kernel Version 21.5.0 root:xnu-8020.121.3~4/RELEASE_ARM64_T8101 arm64 arm While attempting to run extras/install_srilm.sh, am getting the following error message:

MACHINE_TYPE=macosx OPTION= MAKE_PIC= release-programs) || exit 1; \ done make[2]: Nothing to be done for release-programs'. make[2]: Nothing to be done forrelease-programs'. c++ -Wall -Wno-unused-variable -Wno-uninitialized -Wno-overloaded-virtual -DINSTANTIATE_TEMPLATES -DHAVE_LIBLBFGS -I/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/include -I/usr/include -I. -I../../include -DHAVE_ZOPEN -L/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -Wl,-rpath -Wl,/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -u _matherr -L../../lib/macosx -L/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -Wl,-rpath -Wl,/Users/siddharthg/Github-dev/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -g -O2 -fno-common -o ../bin/macosx/ngram ../obj/macosx/ngram.o ../obj/macosx/liboolm.a ../../lib/macosx/libflm.a ../../lib/macosx/libdstruct.a ../../lib/macosx/libmisc.a ../../lib/macosx/libz.a -L/usr/lib -ltcl -lm -llbfgs -liconv 2>&1 | c++filt ld: library not found for -llbfgs clang: error: linker command failed with exit code 1 (use -v to see invocation) test -f ../bin/macosx/ngram make[2]: [../bin/macosx/ngram] Error 1 make[1]: [release-programs] Error 1 make: *** [World] Error 2

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4762, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYXZ4IQFBEQUM73VC2QLVR3RGJANCNFSM52MTKCFQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sidgupta234 commented 2 years ago

I tried running extras/install_liblbfgs.sh getting the following error

checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking build system type... configure: error: /bin/sh ./config.sub -apple-darwin21.5.0 failed
make: *** No targets specified and no makefile found.  Stop.
make: Nothing to be done for `install'.
libLBFGS config is already in env.sh
jtrmal commented 2 years ago

hm, I'm not sure. You can compile srilm without maxent models support as a workaround (there should be switch for that in the install_srilm.sh script) y.

On Fri, Jul 1, 2022 at 10:21 AM Siddharth Gupta @.***> wrote:

I tried running extras/install_liblbfgs.sh getting the following error

checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether to enable maintainer-specific portions of Makefiles... no checking build system type... configure: error: /bin/sh ./config.sub -apple-darwin21.5.0 failed make: *** No targets specified and no makefile found. Stop. make: Nothing to be done for `install'. libLBFGS config is already in env.sh

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4762#issuecomment-1172401969, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX76HMFM5C5BDR2JK6DVR35HHANCNFSM52MTKCFQ . You are receiving this because you commented.Message ID: @.***>

jtrmal commented 2 years ago

hi, any feedback on this?

sidgupta234 commented 2 years ago

Hi, no it didnt work out. I gave up on setting it up on Mac, and used my linux system instead for Kaldi related work.

jtrmal commented 2 years ago

Sorry to hear that. Linux is a better-solution for kaldi and ml/ai anyway (in long term) because of cuda. Imo Y.

On Sat, Aug 13, 2022 at 07:33 Siddharth Gupta @.***> wrote:

Hi, no it didnt work out. I gave up on setting it up on Mac, and used my linux system instead for Kaldi related work.

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4762#issuecomment-1213742999, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX2OUBFETD2BQBKUL53VY4XTHANCNFSM52MTKCFQ . You are receiving this because you commented.Message ID: @.***>

jtrmal commented 2 years ago

also, seems it's related to Apple silicon (M1/M2) y.

On Sat, Aug 13, 2022 at 8:41 AM Jan Yenda Trmal @.***> wrote:

I'll keep opened this to make sure I will remember test this further Y.

On Sat, Aug 13, 2022 at 08:40 Jan Yenda Trmal @.***> wrote:

Sorry to hear that. Linux is a better-solution for kaldi and ml/ai anyway (in long term) because of cuda. Imo Y.

On Sat, Aug 13, 2022 at 07:33 Siddharth Gupta @.***> wrote:

Hi, no it didnt work out. I gave up on setting it up on Mac, and used my linux system instead for Kaldi related work.

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4762#issuecomment-1213742999, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX2OUBFETD2BQBKUL53VY4XTHANCNFSM52MTKCFQ . You are receiving this because you commented.Message ID: @.***>

kkm000 commented 2 years ago

I am closing this issue for now. If you believe that your issue has not been addressed, please feel free to ping me, and I'll reopen it. @-mention me for a faster response!

jtrmal commented 2 years ago

I'll keep opened this to make sure I will remember test this further Y.

On Sat, Aug 13, 2022 at 08:40 Jan Yenda Trmal @.***> wrote:

Sorry to hear that. Linux is a better-solution for kaldi and ml/ai anyway (in long term) because of cuda. Imo Y.

On Sat, Aug 13, 2022 at 07:33 Siddharth Gupta @.***> wrote:

Hi, no it didnt work out. I gave up on setting it up on Mac, and used my linux system instead for Kaldi related work.

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/issues/4762#issuecomment-1213742999, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX2OUBFETD2BQBKUL53VY4XTHANCNFSM52MTKCFQ . You are receiving this because you commented.Message ID: @.***>

bonrybon commented 1 year ago

Hi, is there an update on this issue? I am encountering the same issue above:

make[2]: Nothing to be done for `release-programs'.
c++ -Wall -Wno-unused-variable -Wno-uninitialized -Wno-overloaded-virtual -DINSTANTIATE_TEMPLATES  -DHAVE_LIBLBFGS -I/Users/bonry/kaldi/tools/srilm/../liblbfgs-1.10/include -I/usr/include -I. -I../../include -DHAVE_ZOPEN  -L/Users/bonry/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -Wl,-rpath -Wl,/Users/bonry/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -u _matherr -L../../lib/macosx -L/Users/bonry/kaldi/tools/srilm/../liblbfgs-1.10/lib/ -Wl,-rpath -Wl,/Users/bonry/kaldi/tools/srilm/../liblbfgs-1.10/lib/  -g -O2 -fno-common -o ../bin/macosx/ngram ../obj/macosx/ngram.o ../obj/macosx/liboolm.a  ../../lib/macosx/libflm.a ../../lib/macosx/libdstruct.a ../../lib/macosx/libmisc.a ../../lib/macosx/libz.a -L/usr/lib -ltcl -lm -llbfgs -liconv 2>&1 | c++filt
ld: library not found for -llbfgs
clang: error: linker command failed with exit code 1 (use -v to see invocation)
test -f ../bin/macosx/ngram
make[2]: *** [../bin/macosx/ngram] Error 1
make[1]: *** [release-programs] Error 1
make: *** [World] Error 2

I tried to run extras/install_liblbfgs.sh and this is the results.

checking for a BSD-compatible install... /Users/bonry/kaldi/tools/srilm/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking build system type... configure: error: /bin/sh ./config.sub -apple-darwin22.3.0 failed
make: *** No targets specified and no makefile found.  Stop.
make: Nothing to be done for `install'.
libLBFGS config is already in env.sh
svenemtell commented 1 year ago

I also had the same problem trying to install liblbfgs on macOS 13.2.1 (Apple Silicon). I didn't continue that track, but I guess you could try installing prebuilt binaries from homebrew using brew install liblbfgs and change the include and libraries paths regarding liblbfgs in install_srilm.sh.

nihavend commented 6 months ago

I guess no body is interested in the subject anymore

I got the same error while trying to ./install_srilm.sh

ld: library 'lbfgs' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
test -f ../bin/macosx/ngram
make[2]: *** [../bin/macosx/ngram] Error 1
make[1]: *** [release-programs] Error 1
make: *** [World] Error 2

I have the package install via brew install liblbfgs the script can not get that one

I also get error while trying to ./install_liblbfgs.sh

checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking build system type... configure: error: /bin/sh ./config.sub -apple-darwin23.4.0 failed
make: *** No targets specified and no makefile found.  Stop.
make: Nothing to be done for `install'.
libLBFGS config is already in env.sh

maybe someone cares...

danpovey commented 6 months ago

Is your Kaldi fully up to date? About a week ago or less, I merged something about SRILM installation I think. Also check where your env.sh thinks the LBFGS library is, maybe you moved your tree or we accidentally checked something in there..

nihavend commented 6 months ago

I guess it is fresh new, I just cloned from github (master branch) I changed the blow to the local path and than got the installation completed. Now the install script uses the one that I installed with brew not the one in repo

from

grep ADDITIONAL_LDFLAGS common/Makefile.machine.$mtype | \
    sed 's|$| -L$(SRILM)/../liblbfgs-1.10/lib/ -Wl,-rpath -Wl,$(SRILM)/../liblbfgs-1.10/lib/|' \
    >> common/Makefile.machine.$mtype

to

grep ADDITIONAL_LDFLAGS common/Makefile.machine.$mtype | \
    sed 's|$| -L/opt/homebrew/opt/liblbfgs/lib/ -Wl,-rpath -Wl,/opt/homebrew/opt/liblbfgs/lib/|' \
    >> common/Makefile.machine.$mtype