remove obsoleted and C++17 incompatible unary_function<>, resolves #4732

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.

http://kaldi-asr.org

Other

14.25k stars 5.32k forks source link

remove obsoleted and C++17 incompatible unary_function<>, resolves #4732 #4774

Closed jtrmal closed 2 years ago

jtrmal commented 2 years ago

@danpovey @h-vetinari I took a stab at it -- seems like it's working for C++14, testing C++17 ATM

jtrmal commented 2 years ago

turns out std::random_shuffle() was also removed and needed to be replaced by std:shuffle(begin, end, RNG) which I did in the second commit. @danpovey could you please check if this has any implication on the functionality? Things will be more random now... Tests ran fine both in C++14 and C++17

jtrmal commented 2 years ago

merging