search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.11k stars 5.31k forks source link

automatically compile docker images and push to docker hub #4781

Closed jtrmal closed 2 years ago

jtrmal commented 2 years ago

@mdoulaty, please have a look -- this has run for pushing into my personal space on docker hub. Once you ok this, I will play with it more to get it run monthly or something like that (and remove build on every PR and every merge, which sounds wasteful)

jtrmal commented 2 years ago

there was an issue with secrets sharing within pull requeststs opened from a different fork so instead I just went ahead and made the changes

csukuangfj commented 2 years ago

there was an issue with secrets sharing within pull requeststs opened from a different fork so instead I just went ahead and made the changes

please have a look at https://github.com/k2-fsa/k2/blob/79d9c12b1571f02e6440b955eacf6bd15555cd3c/.github/workflows/nightly-cuda-ubuntu.yml#L21

    if: github.repository == 'k2-fsa/k2'

You can enable this GitHub action only if is invoked from kaldi-asr/kaldi.

jtrmal commented 2 years ago

I'm gonna close this for a while, to stop generating faulty actions.... will have working/testing PR open in jtrmal/kaldi

On Thu, Aug 18, 2022 at 7:49 AM Fangjun Kuang @.***> wrote:

@.**** commented on this pull request.

In .github/workflows/docker-images.yml https://github.com/kaldi-asr/kaldi/pull/4781#discussion_r948673108:

  • with:
  • username: ${{ secrets.DOCKERHUB_USERNAME }}
  • password: ${{ secrets.DOCKERHUB_TOKEN }}
    • name: Inspect builder
  • run: |
  • echo "Name: ${{ steps.buildx.outputs.name }}"
  • echo "Endpoint: ${{ steps.buildx.outputs.endpoint }}"
  • echo "Status: ${{ steps.buildx.outputs.status }}"
  • echo "Flags: ${{ steps.buildx.outputs.flags }}"
  • echo "Platforms: ${{ steps.buildx.outputs.platforms }}"
    • name: Build and push
  • run: |
  • cd docker/ubuntu18.04-cuda10.0/
  • docker build --push --tag kaldiasr/kaldi:gpu-latest --tag kaldiasr/kaldi:gpu-ubuntu18.04-cuda10.0 .

Shall we put a date on the tag so that users can report bugs/issues on a specific tag?

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/pull/4781#pullrequestreview-1076729700, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX7ZID35YPUZFJA4DC3VZXFHRANCNFSM563ZM5PA . You are receiving this because you authored the thread.Message ID: @.***>

jtrmal commented 2 years ago

I do that for the cpu build. I build gpu and CPU images in parallel jobs, so they will be at docker hub within few minutes of each other y.

On Fri, Aug 19, 2022 at 6:49 PM Mortaza (Morrie) Doulaty < @.***> wrote:

@.**** commented on this pull request.

In .github/workflows/docker-images.yml https://github.com/kaldi-asr/kaldi/pull/4781#discussion_r950388148:

  • with:
  • username: ${{ secrets.DOCKERHUB_USERNAME }}
  • password: ${{ secrets.DOCKERHUB_TOKEN }}
    • name: Inspect builder
  • run: |
  • echo "Name: ${{ steps.buildx.outputs.name }}"
  • echo "Endpoint: ${{ steps.buildx.outputs.endpoint }}"
  • echo "Status: ${{ steps.buildx.outputs.status }}"
  • echo "Flags: ${{ steps.buildx.outputs.flags }}"
  • echo "Platforms: ${{ steps.buildx.outputs.platforms }}"
    • name: Build and push
  • run: |
  • cd docker/ubuntu18.04-cuda10.0/
  • docker build --push --tag kaldiasr/kaldi:gpu-latest --tag kaldiasr/kaldi:gpu-ubuntu18.04-cuda10.0 .

I think we should also keep a latest tag that always points to the latest image that's built

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/pull/4781#discussion_r950388148, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX3TRVOKBJMP3HV72V3VZ63ITANCNFSM563ZM5PA . You are receiving this because you modified the open/close state.Message ID: @.***>