search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.11k stars 5.31k forks source link

Do not use ADL to invoke std::binary_search #4809

Closed georgthegreat closed 1 year ago

jtrmal commented 1 year ago

does that fix any particular issue?

georgthegreat commented 1 year ago

This fixes the build again our internal version of STL (and makes the code better).

C++ standard allows using raw pointers as iterators.

jtrmal commented 1 year ago

you would need to include explicitly, I think

On Tue, Dec 6, 2022 at 11:37 AM Yuriy Chernyshov @.***> wrote:

This fixes the build again our internal version of STL (and makes the code better).

C++ standard allows using raw pointers as iterators.

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/pull/4809#issuecomment-1339649449, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX4CA6CAM6XOUMTW46LWL5TVRANCNFSM6AAAAAASVW74OE . You are receiving this because you commented.Message ID: @.***>

georgthegreat commented 1 year ago

If the previous code compiled without it, current one will compile.

There is a bunch of e. g. std::sort invocations in this file. I think <algorithm> is already transitively included.

georgthegreat commented 1 year ago

@jtrmal, do you have any objections against merging this PR?

jtrmal commented 1 year ago

No objection. Will try to get to it today. Sorry for the delay. Y.

On Wed, Dec 14, 2022 at 13:16 Yuriy Chernyshov @.***> wrote:

@jtrmal https://github.com/jtrmal, do you have any objections against merging this PR?

— Reply to this email directly, view it on GitHub https://github.com/kaldi-asr/kaldi/pull/4809#issuecomment-1351223675, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYXYPIYBHSMKUBPJYDVLWNG3ALANCNFSM6AAAAAASVW74OE . You are receiving this because you were mentioned.Message ID: @.***>

stale[bot] commented 1 year ago

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.