search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.11k stars 5.31k forks source link

Add support for CUDA 12 and Hopper. #4817

Closed galv closed 1 year ago

galv commented 1 year ago

CUDA 12, and with it, Hopper support, came out recently FYI. Should be a simple thing to add.

galv commented 1 year ago

Failing with:

extras/check_dependencies.sh: python2.7 is not installed
extras/check_dependencies.sh: Some prerequisites are missing; install them using the command:
  sudo apt-get install python2.7

I fixed this here: https://github.com/kaldi-asr/kaldi/pull/4811/commits/6d94122a6fff59ff618f75a90fb965e433b05333

But I don't want to merge that PR yet, so I will cherry-pick that commit.

jtrmal commented 1 year ago

LGTM, feel free to merge once you feel it's done. The only comment I might have to adding the python2 -- I hope it won't make python2 default system "python", that would probably be very annoying.

jtrmal commented 1 year ago

nevermind, just realized this is for the github actions VM