search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.03k stars 5.3k forks source link

Fix matrix data offset for large matrices #4823

Closed nshmyrev closed 1 year ago

nshmyrev commented 1 year ago

Funny enough it wasn't noticed before.

If we create a big matrix say 2 000 000 x 1280 (10Gb in size), RowData doesn't work properly and causes a segfault. It just overflows int32 while calculating offset.

jtrmal commented 1 year ago

LGTM

stale[bot] commented 1 year ago

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

jtrmal commented 1 year ago

Merging, thanks!

nshmyrev commented 1 year ago

Thank you!