search

kaldi-asr / kaldi

kaldi-asr/kaldi is the official location of the Kaldi project.
http://kaldi-asr.org
Other
14.11k stars 5.31k forks source link

Fix reported issues w.r.t python2.7 and some apple silicone quirks #4924

Closed jtrmal closed 1 month ago

jtrmal commented 1 month ago

@danpovey for your reviewing pleasure ;)

jtrmal commented 1 month ago

@csukuangfj hi, good point, changed. I also fixed the failing tests while I was at it -- authors of the tests forgot that KALDI_ASSERT(cond) calls/evaluates cond twice. LMK

danpovey commented 1 month ago

I'm surprised some of these issues lasted as long as they have, about the templates. anyway looks OK to me.

jtrmal commented 1 month ago

I'm surprised too, but some stuff we ignored and some stuff the older compilers didn't complain about... 🤷