Startup script: pass command as a string to the shell

kaleido-io / quorum-tools

Easily set up Quorum networks using Raft or IBFT with docker

Apache License 2.0

9 stars 17 forks source link

Closed vdamle closed 6 years ago

vdamle commented 6 years ago

changes for cors broke wildcard arguments to wsorigin/cors etc. restore the method to pass command and args as string to shell

Freyert commented 6 years ago

@vdamle this is problematic as we will not know the PID of the geth process since bash -c forks the execution.

Freyert commented 6 years ago

I'll take a swing at this

vdamle commented 6 years ago

No, the PID an be retrieved without any problem. I tested this in my local CI env, here is another example:

Users-MacBook-Pro:tmp vdamle$ sh -c "sleep 100" &
[1] 76909
Users-MacBook-Pro:tmp vdamle$ pid=$!
Users-MacBook-Pro:tmp vdamle$ echo $pid
76909