search

kaleidos / grails-postgresql-extensions

Grails plugin to use postgresql native elements such as arrays, hstores,...
Apache License 2.0
78 stars 62 forks source link

Fix srcDir for precompiling AST Transformations #21

Closed mkobel closed 10 years ago

mkobel commented 10 years ago

Using Grails 2.2.4, compileAST tried to compile in the application instead of the plugin. This is fixed using pluginBaseDir instead of basedir

ilopmar commented 10 years ago

Thank you for your contribution.

I have test it and before accept it I have a question. Is there any problem if the compileAST compiles the application?

With your change the AST is not compiled during the plugin test-app and all the tests related to Hstore fails.

Regards, Iván.

mkobel commented 10 years ago

I did not run test-app. My problem was, that compileAST worked only if i removed the complete project directory from ~/.grails/2.2.4/projects. Afterwards the first run-app was successfull, on later executions, it failed because of the wrong source directory.

Now, I could fix the path using postgresqlExtensionsPluginDir. With this additional commit, running my application and testing the plugin works.

ilopmar commented 10 years ago

Now the plugin tests works fine. I'm going to merge your pull request and release a new version.

Thank you for your contribution :-)

Regards, Iván.

ilopmar commented 10 years ago

Merged and published the new version: http://grails.org/plugin/postgresql-extensions

Regards, Iván.