Grails 2.4 run app issues

[aeischeid]

with a newly created app either with some domains added or with none I can't get it to startup with this plugin installed

Compile error during compilation with javac. /home/aeischeid/dev/grails/sandbox/target/work/plugins/postgresql-extensions-0.6.8/src/java/net/kaleidos/hibernate/criterion/array/PgArrayExpression.java:7: error: cannot find symbol import org.hibernate.engine.TypedValue; ^ symbol: class TypedValue location: package org.hibernate.engine /home/aeischeid/dev/grails/sandbox/target/work/plugins/postgresql-extensions-0.6.8/src/java/net/kaleidos/hibernate/criterion/array/PgArrayExpression.java:9: error: package org.hibernate.util does not exist import org.hibernate.util.StringHelper; ^

and farther down...

/home/aeischeid/dev/grails/sandbox/target/work/plugins/postgresql-extensions-0.6.8/src/java/net/kaleidos/hibernate/usertype/HstoreType.java:99: error: method does not override or implement a method from a supertype @Override ^ /home/aeischeid/dev/grails/sandbox/target/work/plugins/postgresql-extensions-0.6.8/src/java/net/kaleidos/hibernate/usertype/HstoreType.java:107: error: method does not override or implement a method from a supertype @Override ^ /home/aeischeid/dev/grails/sandbox/target/work/plugins/postgresql-extensions-0.6.8/src/java/net/kaleidos/hibernate/usertype/IntegerArrayType.java:11: error: IntegerArrayType is not abstract and does not override abstract method nullSafeSet(PreparedStatement,Object,int,SessionImplementor) in UserType public class IntegerArrayType extends AbstractArrayType{ ^ /home/aeischeid/dev/grails/sandbox/target/work/plugins/postgresql-extensions-0.6.8/src/java/net/kaleidos/hibernate/usertype/IntegerArrayType.java:24: error: method does not override or implement a method from a supertype @Override ^ /home/aeischeid/dev/grails/sandbox/target/work/plugins/postgresql-extensions-0.6.8/src/java/net/kaleidos/hibernate/usertype/IntegerArrayType.java:35: error: method does not override or implement a method from a supertype @Override

[ilopmar]

Wooow! what a coincidence! I'm at GR8Conf at Copenhagen and at the end of the first day (today) we've a hackergarten to contribute to some opensource projects. Just about one hour ago I've pushed a new branch with some changes to make the plugin compatible with grails 2.4 and hibernate 4.0.

You can check the temporal commit, and I mean temporal. I'm not finished the job and I'm going to remove this commit and create some other commits that have more sense. Right now this commit is a backup of the work that I've been doing. The commit is d4fa7a0eb703d0d2c30fc285f327ffed86da0e9c

What I'm going to do is to cleanup old the code but then @Alotor and me have to decide what to do with this plugin and the support of different hibernate versions. As you can see in the previous commit some classes have been moved to another packages, the hibernate user type has new signature in some methods and also the dialect we were using is deprecated. With the changes of this commit the plugin now passes all the tests. I'm not really sure if the best option is to maintain the same plugin compatible with two different versions of hibernate or the best option is to create a new plugin (just like grails-hibernate and grails-hibernate4 plugins). What do you think about that?

Then I'm going to create a new grails 2.4 application and test the plugin inside it. This is gonna take some days.

Regards, Iván.

[aeischeid]

I am really glad to have this plugin so glad to hear you guys are still going on it!

Hope you're having a great time at the conference. I might make it to GR8Conf US this year, but the one in Denmark is a bit far for me.

As for a new plugin or sticking with just one. It kind of depends. If you want to maintain AND add features for users of both hibernates two plugins is probably the way to go. If you are pretty much feature complete and relatively bug free in hibernate 3 (as far as you know) then simply a version bump and some comments in the docs (as the mongo and many other plugin do) may be enough. either way you can probably just keep them as branches in this one repo. maybe... actually not sure if that is possible with the way you publish grails plugins these days. It would have worked in the past, though.

[ilopmar]

Hi!

I've published a new 1.0.0-SNAPSHOT version with the changes in the new branch (which I've cleaned up).

Please, try with this version and check the documentation (https://github.com/kaleidos/grails-postgresql-extensions#release-notes) because the last oficial release is 0.8.1 instead of 0.6.8.

Regards, Iván.

[aeischeid]

I didn't have time to get to this today, but plan to give it a run after the weekend.

[ilopmar]

Fixed in version 4.0.0 of the plugin.