search

kaleidos / grails-postgresql-extensions

Grails plugin to use postgresql native elements such as arrays, hstores,...
Apache License 2.0
78 stars 62 forks source link

Update ArrayType.java #41

Closed Taack closed 10 years ago

Taack commented 10 years ago

fix some problems when executing code sample shown in the documentation. Another fix is to change Float with Double.

Taack commented 10 years ago

merge this pull request to fix enum in domain class.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 8cda6361d86cd3499afe11e4c07aec3e470a8174 on AdrienGuichard:patch-1 into 8a5243cd6bb46c3483da3f15fce15dcfbf65ef1b on kaleidos:master.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 8cda6361d86cd3499afe11e4c07aec3e470a8174 on AdrienGuichard:patch-1 into 8a5243cd6bb46c3483da3f15fce15dcfbf65ef1b on kaleidos:master.

Alotor commented 10 years ago

Thanks for the PR!

Before merging it, can you add a test that didn't pass before the PR? This way we can avoid future regressions.

Taack commented 10 years ago

Unit tests are all OK from the git repository on my system (without any code change).

In my code, 'table "pg_extensions_like"' was missing in mapping section (I copy/past code from the main documentation). This should explain the problems I do have...

Thanks!

2014-07-22 19:38 GMT+02:00 Alonso Torres notifications@github.com:

Thanks for the PR!

Before merging it, can you add a test that didn't pass before the PR? This way we can avoid future regressions.

— Reply to this email directly or view it on GitHub https://github.com/kaleidos/grails-postgresql-extensions/pull/41#issuecomment-49773662 .

ilopmar commented 10 years ago

@AdrienGuichard so finally it's necessary this PR or is everything ok?

Taack commented 10 years ago

Everything is OK! Le 23 juil. 2014 15:25, "Iván López" notifications@github.com a écrit :

@AdrienGuichard https://github.com/AdrienGuichard so finally it's necessary this PR or is everything ok?

— Reply to this email directly or view it on GitHub https://github.com/kaleidos/grails-postgresql-extensions/pull/41#issuecomment-49872529 .

ilopmar commented 10 years ago

Ok, so we close the PR.

Thanks!