search

kaleidos / grails-postgresql-extensions

Grails plugin to use postgresql native elements such as arrays, hstores,...
Apache License 2.0
78 stars 62 forks source link

cleanup #54

Closed burtbeckwith closed 9 years ago

burtbeckwith commented 9 years ago

FYI - in HstoreHelper.asStatement() the "key" variable isn't used.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.04%) when pulling c624c5f79ee83ed784c7e507e15ca43aa656f813 on burtbeckwith:master into daf764247bc9cbc1cffee823754bf6212e12a0a7 on kaleidos:master.

ilopmar commented 9 years ago

Thank you very much for the PR. I'll try to merge it in the following days :-)

Alotor commented 9 years ago

Hello Burt and Happy New year :smile:

Why did you remove the "@Override" annotations? We wanted to put them so if the Hibernate API changes the compiler warns us that the method is not implemented.

burtbeckwith commented 9 years ago

I only removed @Overrides from methods implementing interface methods. This is optional and I've never understood why anyone does this. If you fail to implement a method, there are better ways to discover that, e.g. your class won't compile :)

Feel free to revert any change that I made - consider everything just a suggestion.

ilopmar commented 9 years ago

Thank you Burt for your cleanup. I've reverted only some minor changes.

Regards, Iván.