search

kaleissin / CALS

Conlang Atlas/Archive of Language Structures
11 stars 0 forks source link

Editing & viewing translations still not quite right #31

Closed spikedee closed 9 years ago

spikedee commented 9 years ago

It appears the translations system has acquired a few kinks since my last adventure in bug reporting.

When you click on a translation, like so: testarosa-clicky

You not gonna get it all, yo, 'cause this error appears:

testarosa-fail

The username of the translator appears in the URL (highlighted), e.g. if someone were to click on one of my translations, "admin" in the URL above would be "spikedee." I suspect that this has something to do with the issue. (Edit: It works correctly if you remove the username from the URL, which seems to corroborate my suspicions. No idea why I didn't think to actually try that to start with, given said suspicions.)

I originally got this hunch because when you click on a link to one of your own translations, it appears to work correctly, taking you to the page to edit the translation. But when you actually try to submit an edit, you get an error message exactly like the first one (I guess it doesn't want me to touch it there...):

no-edits-4-u

(Edit 2: Even though it throws this error again, the edit does go through successfully. Guess it has mixed feelings about touching it there...)

(Oh yeah, the conlang in the screenshot above is in all likelihood a much bigger mess than this at the moment. It's one I'm working on for a friend's world-building project, and it's been undergoing a major overhaul and lots of tinkering recently to better suit her tastes, but I seriously digress.)

Also, I didn't know about the CALS github until the admin showed me when I went bug-reporting before; thanks for that! I hope this bug report is a bit more helpful than the last. A link on the main site to the CALS' issues page on github would be helpful too, hinthint nudgenudge. Or maybe I just overlooked it.

kaleissin commented 9 years ago

Thanks for the most excellent bug report! With screenshots even!

I have a pretty good idea what causes these 404s, the pages use outdated code to build the url.

kaleissin commented 9 years ago

Whoa, with urls even, this'll be a walk in the park!

kaleissin commented 9 years ago

See if it all works out as expected at the dev-site: http://dev.cals.nu/translation/ What you do there will be reflected in the main site, the difference is all things debugging are turned on.

spikedee commented 9 years ago

Yep, everything seems to be working fine. :+1:

I used to have a job as a software tester and bug-catcher. Learnt very quickly that you can pretty much never be too thorough or include too many screenshots in bug reports unless you're trying to be useless on purpose or something. Also gradually developed an intuition for pointing devs to probable causes of issues.

kaleissin commented 9 years ago

Good testers don't grow on trees! They also save a lot of time, prevent heart burn, and aren't paid enough =)

The fixes are in production, the source have been pushed, closing this issue.