search

kalekiu / easyesn

Python library for Reservoir Computing using Echo State Networks
131 stars 37 forks source link

adding torch backend support, better cupy support and better PredictionESN & BaseESN usage of backends #14

Closed denisj44 closed 3 years ago

denisj44 commented 4 years ago

adding torch backend support, better cupy support and better PredictionESN & BaseESN usage of backends

Fast performance ahead

zimmerrol commented 4 years ago

Thanks for the PR @denisj44! I think somehow the diff got broken for the files you modified in the last commit: it now appears as if you have deleted the entire file, replaced it with almost the same code, and then made the modifications... This will make it very difficult to trace back modifications in the future. Do you mind correcting this and making sure the git/GitHub diff is still working fine and really only detects your changes?

Thanks!

Edit: Yes, this was because of the line endings you used. Please use the proper line endings. To fix this, please run inside the repository

git config core.autocrlf true
git add --renormalize .
git commit -m "Fix line endings"
darreal44 commented 3 years ago

Thanks for the PR @denisj44! I think somehow the diff got broken for the files you modified in the last commit: it now appears as if you have deleted the entire file, replaced it with almost the same code, and then made the modifications... This will make it very difficult to trace back modifications in the future. Do you mind correcting this and making sure the git/GitHub diff is still working fine and really only detects your changes?

Thanks!

Edit: Yes, this was because of the line endings you used. Please use the proper line endings. To fix this, please run inside the repository

git config core.autocrlf true
git add --renormalize .
git commit -m "Fix line endings"

This has been done + a new optimization for numpy-scipy code. Merry Christmas

darreal44 commented 3 years ago

Sorry about the delay but I don't find too much time to work on this (most often during holidays)

darreal44 commented 3 years ago

The latest scipy improvement is accelerating a lot computations without gpu... My own computations was taking 6 hours it now reduces it to 4h... I am looking to much more improvements but I am uncertain to succeed.

darreal44 commented 3 years ago

Oh yes I am @denisj44 and @darreal44 as you can see...

zimmerrol commented 3 years ago

Thanks for your work @denisj44 !