search

kalemaria / pycurv

Reliable estimation of membrane curvature for cryo-electron tomography
GNU Lesser General Public License v3.0
16 stars 6 forks source link

Update python_requires #3

Closed bbarad closed 4 years ago

bbarad commented 4 years ago

When trying to install with pip -e, I had to make this change to install with python 3.7.3. Not sure if python setup.py install would have handled it better, but I suspect it would not hurt it.

kalemaria commented 4 years ago

@bbarad Thank you so much for trying to install PyCurv and for your fix! I have merged it now, sorry for the delay. I have not tried to install it with pip -e, did it work well? I believe adding >= instead of == will not hurt for python setup.py install.

bbarad commented 4 years ago

I was able to install just fine! Still working on the surfaces I want to feed into the system, but everything works nicely with pip -e (I also wrote a setup.py script for that so I could manage it with pip... will add a pull request for that later.). It might also be worth updating the readme now that pyto is open source - I wrote to Dr. Lucic and he kindly redirected me here: https://github.com/vladanl/Pyto.

kalemaria commented 4 years ago

Great, I did not know yet that Pyto is on GitHub! I will update the Readme tomorrow, thanks for pointing this out. May I ask from which technique and sample do you have the surfaces, cryo-ET and membranes or something else?

bbarad commented 4 years ago

CryoET of mammalian mitochondria in fibbed cells! Challenging due to lots of high curvature areas in the cristae, but hoping to quantify that some with the curvature calculations!

kalemaria commented 4 years ago

Oh yes, mitochondria must be very time consuming to segment! What are you using for the segmentation? Good luck and let me know whether you have any issues with the curvature calculations.