search

kalenjordan / custom-reports

Custom Magento reports using SQL
http://magemail.co/free-custom-reports-module-for-magento/
Other
143 stars 65 forks source link

Fixed clickable URLs for columns, code by @sreichel #66

Closed peterjaap closed 8 years ago

peterjaap commented 8 years ago

Fixed clickable URLs for columns, code by @sreichel, also added hide option and updated README.

This fixes #51

Thanks @sreichel

peterjaap commented 8 years ago

@kalenjordan, can you check this out?

kalenjordan commented 8 years ago

@peterjaap genius - on a high level love the idea. Took a quick peek at the code. You want a deep dive code review?

peterjaap commented 8 years ago

I did, works perfectly On Sun, 23 Oct 2016 at 18:19, kalenjordan notifications@github.com wrote:

@peterjaap https://github.com/peterjaap genius - on a high level love the idea. Took a quick peek at the code. You want a deep dive code review?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kalenjordan/custom-reports/pull/66#issuecomment-255597632, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaVAG0g2tzGttnqUakveIIl5bwwK8Twks5q24kIgaJpZM4Kd5kU .

kalenjordan commented 8 years ago

Sweet anything you need from me? @peterjaap

peterjaap commented 8 years ago

No it just needs a version bump, will try and get around to it later this week. On Tue, 25 Oct 2016 at 20:45, kalenjordan notifications@github.com wrote:

Sweet anything you need from me? @peterjaap https://github.com/peterjaap

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kalenjordan/custom-reports/pull/66#issuecomment-256135398, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaVACGDpdAVDXkOcX0T4a6IcXdCtwqpks5q3k5CgaJpZM4Kd5kU .