search

kalepail / stellar-quest-bounties

Stellar Quest Bounties is an extension of the traditional, series based Stellar Quest challenges allowing seasoned and passionate Stellar Questers to continue their journey of education and earning during the "lean times" between Stellar Quest series.
https://quest.stellar.org/bounties
24 stars 27 forks source link

Basic Account Viewer by firdausfarul #126

Open Firdausfarul opened 3 years ago

Firdausfarul commented 3 years ago

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-1/basic-account-viewer.md

Mark your progress

Provide relevant details

Repository : https://github.com/Firdausfarul/StellarAccountViewer/tree/master

Demo : https://firdausfarul.github.io/StellarAccountViewer/

hanseartic commented 3 years ago

Thank you for your submission! I did not go into details, yet but what I caught upfront is the non-functional https connection: image Even though everything should be handled in the browser it's essential for the trust to provide a secure connection. I would really appreciate that being changed. Looking forward to take a deeper look later.

Firdausfarul commented 3 years ago

Changed the link to default github pages domain so it's https secured. The free domain that came with student dev pack doesn't came with free SSL.

raeesnazeer commented 3 years ago

That Looks good, it passes all the conditions required for the bounty, but the log out button being visible even before logging In makes it look odd. you can try making it visible only once the user logins.

Other than that it's good to go!

LorDDark6660 commented 2 years ago

if I'm trying to connect from a mobile device with Freighter button, it appears that I'm connected even when I'm not, it would be good to post some error message. I have not Freighter installed. Screenshot_2021-12-11-22-51-53-10_40deb401b9ffe8e1df2f1cc5ba480b12

BlackBadPinguin commented 2 years ago

For me, it works fine on mobile and desktop @LorDDark6660

Now onto your submission @Firdausfarul, the code looks fine and is well documented, may be some spelling errors in the comments, but apart from that, it looks very decent. It does exactly what has been proposed in the Bounty and the Website is well-formatted. I especially like the logout button which is a nice addition. Also that you have alerts when the specific wallet isn't installed is a nice detail. From my side of things, your submission is ready for a reward.

alejomendoza commented 2 years ago

@Firdausfarul When you reject the connection with Freighter the ui looks as you are still trying to connect. I like this is super simple viewer, but still some error handling to do. Same as what @LorDDark6660 mentioned.

BlackBadPinguin commented 2 years ago

Are you still working on it?