kalepail / stellar-quest-bounties

Stellar Quest Bounties is an extension of the traditional, series based Stellar Quest challenges allowing seasoned and passionate Stellar Questers to continue their journey of education and earning during the "lean times" between Stellar Quest series.
https://quest.stellar.org/bounties
23 stars 27 forks source link

Basic Account Viewer by boonku #133

Closed boonku closed 2 years ago

boonku commented 2 years ago

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-1/basic-account-viewer.md

Mark your progress

Provide relevant details

Repository: https://github.com/boonku/boonku.github.io

Demo: https://boonku.github.io

raeesnazeer commented 2 years ago

Hello,

Looks good, but why have you disabled the Freighter and Rabet buttons?

Kanaye commented 2 years ago

Looks good, but why have you disabled the Freighter and Rabet buttons?

Take a look at the codebase: https://github.com/boonku/boonku.github.io/blob/6f53daa214ba91aeeb1dd71f1cd3b52c4ced6dd2/active-buttons.js#L1-L6 the buttons are disabled, when the extensions aren't installed/available, which makes sense imho.

raeesnazeer commented 2 years ago

Looks good, but why have you disabled the Freighter and Rabet buttons?

Take a look at the codebase: https://github.com/boonku/boonku.github.io/blob/6f53daa214ba91aeeb1dd71f1cd3b52c4ced6dd2/active-buttons.js#L1-L6 the buttons are disabled, when the extensions aren't installed/available, which makes sense imho.

image I have the rabet extension installed, but it still remains disabled.

boonku commented 2 years ago

It should be working now. I have also added tooltips for buttons to show why they are disabled.

raeesnazeer commented 2 years ago

It should be working now. I have also added tooltips for buttons to show why they are disabled.

Yes, it's perfect now!

Good job! The review is completed from my end. Looking forward to more submissions!

boonku commented 2 years ago

Thanks

kalepail commented 2 years ago

2c912df8971be87c9b1c0edb42ed632318015d1ae9b9e580869a53749a7222ff