Basic Account Viewer by sohanrai

kalepail / stellar-quest-bounties

Stellar Quest Bounties is an extension of the traditional, series based Stellar Quest challenges allowing seasoned and passionate Stellar Questers to continue their journey of education and earning during the "lean times" between Stellar Quest series.

https://quest.stellar.org/bounties

23 stars 27 forks source link

Basic Account Viewer by sohanrai #147

Closed sohanrai closed 2 years ago

sohanrai commented 2 years ago

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-1/basic-account-viewer.md

Mark your progress

[X] 🔵 Started working
[X] 🟢 Ready for review
[x] 🟣 Review completed

Provide relevant details

Repo: https://github.com/sohanrai/Basic-Account-Viewer-for-Stellar

Demo: https://sohanrai.github.io/Basic-Account-Viewer-for-Stellar/

raeesnazeer commented 2 years ago

Hello,

Please share the demo link.

raeesnazeer commented 2 years ago

Everything looks fine and works well, only one mistake is the freighter button when not installed goes to the rabet.io link, fix that and rest is good to go.

sohanrai commented 2 years ago

Yes, the issue is fixed.

Kanaye commented 2 years ago

I'd personally prefer to move the script to it's own file, just looks cleaner. And to use either a DOM-Api (document.createElement and similar) to modify the DOM instead of innerHTML as it doesn't leave your app open for XSS attacks. In this case it shouldn't matter much as the only user provided value is the asset code which got enough limitations to mitigate most if not all XSS attacks. So I'll leave both decisions up to you ;) Everything else looks good to me 👍

kalepail commented 2 years ago

eeb57db172e5d6db181bed72d8d61c08bba1401298f651505c1438c829205426