search

kalepail / stellar-quest-bounties

Stellar Quest Bounties is an extension of the traditional, series based Stellar Quest challenges allowing seasoned and passionate Stellar Questers to continue their journey of education and earning during the "lean times" between Stellar Quest series.
https://quest.stellar.org/bounties
23 stars 27 forks source link

Basic Account Viewer by vinamogit #150

Closed vinamogit closed 2 years ago

vinamogit commented 2 years ago

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-1/basic-account-viewer.md

Mark your progress

Provide relevant details

Github repository: https://github.com/vinamogit/stellar-account-viewer

Demo: https://vinamogit.github.io/stellar-account-viewer/

raeesnazeer commented 2 years ago

Hello,

Very nicely done, loved the chart representation and display of balance with icons!

The only issue I see is the freighter button doesn't respond if the extension is not installed, so it's better to add a check for that and notify users to install it.

Rest everything is perfect and lovely. Once you fix the freighter issue you can mark is review completed from my end.

Excellent Job!

vinamogit commented 2 years ago

Hello,

Thank you for the feedback. I will fix that soon.

vinamogit commented 2 years ago

Bug fixed.

kalepail commented 2 years ago

Nicely done! Can you add your Stellar address you'd like to receive award payments at as a PR to this file? https://github.com/tyvdh/stellar-quest-bounties/blob/main/ADDRESSES.yml

vinamogit commented 2 years ago

Done. Thank you.

kalepail commented 2 years ago

f46a4b3bb22f784a4ba5effc10639fe358c182294d3ec8e3bffc7fd478c4e649

raeesnazeer commented 2 years ago

f46a4b3bb22f784a4ba5effc10639fe358c182294d3ec8e3bffc7fd478c4e649

Looks like you sent the reviewer bounty to wrong address.

vinamogit commented 2 years ago

Confirm. Is it ok if I send it back to the source account @tyvdh ?

kalepail commented 2 years ago

Confirm. Is it ok if I send it back to the source account @tyvdh ?

Yeah that would be great, thanks. Geeze I swear I triple check these. I wonder if there's a bug with the duplicate op button in lab where editing the destination value doesn't actually update the op 🤔

kalepail commented 2 years ago

fa38180928b2d1d196e364aab25cd912064e6d2b29e012c60a40842c21de98c2

vinamogit commented 2 years ago

ed53d20b214cd8f68366ef1dd1644a97a4a676511b06dd4efdfd9b63476d548e