search

kalepail / stellar-quest-bounties

Stellar Quest Bounties is an extension of the traditional, series based Stellar Quest challenges allowing seasoned and passionate Stellar Questers to continue their journey of education and earning during the "lean times" between Stellar Quest series.
https://quest.stellar.org/bounties
24 stars 27 forks source link

New bounty for Fee Stats in Lab Endpoint Explorer #155

Closed w00kie closed 2 years ago

w00kie commented 2 years ago

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-1/create-bounties.md

Mark your progress

Provide relevant details

As requested by @tyvdh, we should have a bounty for someone to make a PR for adding missing Horizon endpoints, e.g. the Fee Stats endpoint, to the Lab's Endpoint Explorer.

PR: https://github.com/tyvdh/stellar-quest-bounties/pull/156

silence48 commented 2 years ago

I like this idea. I would really like to have an automatic fee estimator for times that surge pricing is in effect on the 'create-transactions' page.

kalepail commented 2 years ago

I like this idea. I would really like to have an automatic fee estimator for times that surge pricing is in effect on the 'create-transactions' page.

Probably a separate bounty but worth looking into. I'm not sure the fee isn't already automatically calculated. I know it's not always 100, I just don't know what the calculation / logic is atm

silence48 commented 2 years ago

I like this idea. I would really like to have an automatic fee estimator for times that surge pricing is in effect on the 'create-transactions' page.

Probably a separate bounty but worth looking into. I'm not sure the fee isn't already automatically calculated. I know it's not always 100, I just don't know what the calculation / logic is atm

It has always shown 100 for me even during surge pricing times; i will try to check on it.

Kanaye commented 2 years ago

It has always shown 100 for me even during surge pricing times; i will try to check on it.

https://github.com/stellar/laboratory/blob/5dfac1ccea143fe1c7aeb24471df08851e455932/src/actions/transactionBuilder.js#L101-L117 that's were they fetch it (used via the store from the transaction builder) ;)

w00kie commented 2 years ago

@tyvdh, fyi I did not put a bounty amount as I thought that should be left to you.

kalepail commented 2 years ago

Pretty low, this one should be quite simple as far as a PR is concerned. Let's shoot for 300 XLM and see if anyone takes it.

ElliotFriend commented 2 years ago

7fce11ebde2fce95300a4105a01e786bfa184867d226589e45f0476e058affa8