search

kalepail / stellar-quest-bounties

Stellar Quest Bounties is an extension of the traditional, series based Stellar Quest challenges allowing seasoned and passionate Stellar Questers to continue their journey of education and earning during the "lean times" between Stellar Quest series.
https://quest.stellar.org/bounties
24 stars 27 forks source link

SEP-10 implementation by orsab #169

Closed orsab closed 2 years ago

orsab commented 2 years ago

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-2/sep10-javascript-server.md

Mark your progress

Provide relevant details

REPO: https://github.com/orsab/stellar-bounty-l2-sep10 Demo on Repl.it: https://replit.com/@OrAlkin/stellar-bounty-l2-sep10

DFugere1 commented 2 years ago

Hi,

Nice implementation of SEP-0010 server.

Testing the solution: I tested your implementation of SEP-0010 with the Rabet Wallet, the implementation always return the Rabet wallet with network as the Main Network.

When testing I could authenticate using the server implementation and I received my JWT auth bearer Token.

Testing the API Everything worked fine when using correctly.

When using incorrectly:

Validating the JWT The JWT seem relevant and complete, it contain a header, a payload containing information for the Issuer, subject, issued time and expiration time and the signature.

Authentication Flow There is one step from the stellar-protocol I can't seem to validate, how do you confirm the signature is correct for the Client Account? (Step 15)

BlackBadPinguin commented 2 years ago

Overall nice Submission!

I tested the Implementation of your API and it looks good, everything seems according to spec. Also, the use of muxed Accounts does not produce any Errors which is good. The Authentication Flow works fine, apart from Step 15 as already mentioned in the issue from @DFugere1. However, the JWT is good. I tested it with the JS SDK.
Also, I still have to test the UI, will update the comment when done.

orsab commented 2 years ago

Hi @DFugere1 , @BlackBadPinguin . Thank you for yours code review, just fixed some bugs you mentioned me, like: signatures check, UX improvements and some bugs with Rabet wallet on testnet.

ElliotFriend commented 2 years ago

2083a0a677111a86e8d429b76786559d765834bcb8d47eb2d66a889bdce9a544