search

kalepail / stellar-quest-bounties

Stellar Quest Bounties is an extension of the traditional, series based Stellar Quest challenges allowing seasoned and passionate Stellar Questers to continue their journey of education and earning during the "lean times" between Stellar Quest series.
https://quest.stellar.org/bounties
23 stars 27 forks source link

Basic account viewer by huuquyet #178

Closed huuquyet closed 2 years ago

huuquyet commented 2 years ago

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-1/basic-account-viewer.md

Mark your progress

Provide relevant details

Repository: https://github.com/huuquyet/basic-account-viewer Demo: https://huuquyet.github.io/basic-account-viewer

DieKautz commented 2 years ago

Your application looks cool. I really like your mobile first approach in the responsiven structure of the ui. For me all key functionalities are working fine e.g. viewing testnet/pubnet balances and date/origin of account creation.

I see you also added a second tab 'settings', do you already have something in your mind you want to customize in your app?

BlackBadPinguin commented 2 years ago

Hello, I looked into your submission and it looks very functional (in a good way). The native and custom Balances get shown correct. Freighter login also works fine. The UI is very minimalistic and I like that. Code wise it looks good, the Readme is clear and understandable. However I think a few comments in the Code wouldn't hurt it. Overall tho great submission.

huuquyet commented 2 years ago

Thank you for kind comments, I'm so happy reading those. I just want to customize dark mode in the settings tab :) And I will remember to comment more

LorDDark6660 commented 2 years ago

Hi, everything works fine for me, I agree with the comments above. instead of the "settings" button just place the "DARK mode" button, I think otherwise there is not much to set. good job

BlackBadPinguin commented 2 years ago

Don't forget to add your name and Stellar Address to the ADDRESSES.yml file with a PR. When you did that you can mark this bounty as ready for a reward. Anything else to say? @DieKautz @LorDDark6660

huuquyet commented 2 years ago

Thank you for all your supports, I really appreciate those.

ElliotFriend commented 2 years ago

Great work, @huuquyet! I particularly like how your account viewer displays the liquidity pool assets, too! I see your PR with your address, as well. As soon as we get all your kyc info, I'll get your payment issued 👍🏻

Thanks!

ElliotFriend commented 2 years ago

Hey, everyone! Tyler got the payout submitted yesterday. Here's the hash:

b8c43e1b63141e35ac942622290772c821b68fc70ff1e0d89282177219d3717f

Thanks everyone for your work, both coding and reviewing!