search

kalessil / phpinspectionsea

A Static Code Analyzer for PHP (a PhpStorm/Idea Plugin)
https://plugins.jetbrains.com/plugin/7622?pr=phpStorm
Other
1.45k stars 118 forks source link

@noinspection triggers Unknown Inspection notices #1901

Closed lostfocus closed 2 months ago

lostfocus commented 1 year ago
Subject Details
Plugin Php Inspections (EA Extended) 5.0.0.0
Language level any

Current behaviour

Ever since I updated PHPStorm to the latest version (see below) I get notices for unknown inspections when marking things with @noinspection

Screenshot 2023-08-10 at 15 31 45

Expected behaviour

PHPStorm/the plugin should know the inspections.

Environment details

PhpStorm 2023.2 Build #PS-232.8660.205, built on July 28, 2023 Runtime version: 17.0.7+7-b1000.6 x86_64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. macOS 13.5 GC: G1 Young Generation, G1 Old Generation Memory: 4096M Cores: 12 Metal Rendering is ON Registry: debugger.new.tool.window.layout=true run.processes.with.pty=TRUE ide.experimental.ui=true

Non-Bundled Plugins: ideanginx9 (0.1.9) main.kotlin.com.jimschubert.intellij.swaggercodegen (4.3.1-p0) some.awesome (1.14) com.github.catppuccin.jetbrains (2.2.0) com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0) ru.adelf.idea.dotenv (2023.2) de.espend.idea.php.toolbox (6.2.0) de.espend.idea.php.annotation (9.4.0) fr.adrienbrault.idea.symfony2plugin (2022.1.253) com.intellij.lang.jsgraphql (4.0.2) zielu.gittoolbox (500.0.13+213)

cebas commented 1 year ago

same problem here

PhpStorm 2023.2.2 Build #PS-232.9921.55, built on September 15, 2023 Runtime version: 17.0.8+7-b1000.22 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Linux 6.2.0-33-generic GC: G1 Young Generation, G1 Old Generation Memory: 5000M Cores: 32 Registry: suggest.all.run.configurations.from.context=true debugger.new.tool.window.layout=true run.processes.with.pty=TRUE ide.experimental.ui=true

Non-Bundled Plugins: lechuck.intellij-plugin.task (1.5.0) com.intellij.ideolog (222.1.0.0) com.sburlyaev.terminal.plugin (0.5.2) com.github.copilot (1.2.22.3129) CMD Support (1.0.5) dev.meanmail.plugin.nginx-intellij-plugin-pro (2022.1.1) com.tabnine.TabNine (1.7.0) org.asciidoctor.intellij.asciidoc (0.39.7) com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0) com.github.b3er.idea.plugins.arc.browser (0.32) GrepConsole (12.21.0-IJ2021.1) ru.adelf.idea.dotenv (2023.2) pro.bashsupport (3.3.0.232) net.seesharpsoft.intellij.plugins.csv (3.2.1-232) mobi.hsz.idea.gitignore (4.5.1) org.jetbrains.settingsRepository (232.9921.28)

Current Desktop: KDE

fietserwin commented 1 year ago

Same here on PhpStorm 2023.2.2 Build #PS-232.9921.55, built on September 15, 2023 Runtime version: 17.0.8+7-b1000.22 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 11.0

The exact message is "[EA] Unknown inspection: .".

Also, I tend to document why an inspection is ignored (instead of preventing it), e.g.

/**
 * @noinspection PhpIllegalPsrClassPathInspection  Bootstrap file is loaded directly.
 */

in which case the message becomes "[EA] Unknown inspection: Bootstrap."

The latter may be an error in itself, or a hint towards what is going wrong.

BenParizek commented 1 year ago

Running into this as well. Intrigued by the observation of @fietserwin above, it seems that when I add the name of the inspection to ignore twice, it gets the inspection error to go away. Probably not the ideal solution, but perhaps another hint at what's going on. And for those of us in constant pursuit of making the squigglies go away, an option to consider.

/**
 * @noinspection PhpIllegalPsrClassPathInspection PhpIllegalPsrClassPathInspection
 */
fietserwin commented 1 year ago

[EDITED: it does make this inspection message go away, but it will reintroduce the message to be suppressed, so this is in no way a workaround]

Even easier, just putting a colon, or in fact just anything, between the @noinspection and the inspection name, makes the message go away:

/*
 * @noinspection: PhpStaticAsDynamicMethodCallInspection
 */
JParkinson1991 commented 1 year ago

Same issue.

Also @fietserwin your colon workaround is not viable, as it actually disables the noinspection and phpstorm will lint/highlight the things you're trying to suppress.

PhpStorm 2023.2.2
Build #PS-232.9921.55, built on September 15, 2023
...
Runtime version: 17.0.8+7-b1000.22 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.1
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 10
Metal Rendering is ON
Registry:
    run.processes.with.pty=TRUE
    ide.balloon.shadow.size=0

Non-Bundled Plugins:
    com.nasller.CodeGlancePro (1.7.6)
    org.intellij.plugins.hcl (232.8660.88)
    org.jetbrains.plugins.go-template (232.9921.89)
    Key Promoter X (2023.2.0)
    com.intellij.plugin.adernov.powershell (2.2.0)
    com.intellij.kubernetes (232.9921.86)
    com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0)
    ru.adelf.idea.dotenv (2023.2)
    de.espend.idea.php.toolbox (6.2.0)
    de.espend.idea.php.annotation (9.4.0)
    com.atlassian.bitbucket.references (2022.1.242)
    Gitflow-Fix (0.7.13)
    zielu.gittoolbox (500.0.21+222)
    mobi.hsz.idea.gitignore (4.5.2)
    de.espend.idea.php.phpunit (7.1)
VhelCodez commented 9 months ago

Same issue here. Anything new about this one?

PhpStorm 2023.3.4
Build #PS-233.14475.35, built on February 13, 2024
...
Runtime version: 17.0.10+1-b1087.17 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
Memory: 6144M
Cores: 12
Registry:
  debugger.new.tool.window.layout=true
  run.processes.with.pty=TRUE
  ide.experimental.ui=true
Non-Bundled Plugins:
  alxmag.dcp (1.0.1)
  com.mnr.java.intellij.idea.plugin.base64helper (3.0.0)
  cn.jxzhang.plugin.json-formatter (1.4)
  String Manipulation (9.12.0)
  org.sylfra.idea.plugins.linessorter (1.0.1)
  ChatGPT (3.2.0-231.233)
  com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0)
  ru.adelf.idea.dotenv (2024.1)
  zielu.gittoolbox (500.1.11+222)
Simbiat commented 8 months ago

Same thing in 2023.3.6

PhpStorm 2023.3.6
Build #PS-233.15026.12, built on March 21, 2024
Licensed to simbiat.ru / Dmitry Kustov
Subscription is active until May 11, 2024.
For non-commercial open source development only.
Runtime version: 17.0.10+1-b1087.23 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
Memory: 5120M
Cores: 16
Registry:
  debugger.new.tool.window.layout=true
  run.processes.with.pty=TRUE
  ide.experimental.ui=true
Non-Bundled Plugins:
  com.jetbrains.space (233.15026.16)
  com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0)
asgraf commented 7 months ago

Same thing on 2024.1 RC (tested via Jetbrains Gateway)

PhpStorm 2024.1 RC
Build #PS-241.14494.159, built on March 21, 2024
...
Runtime version: 17.0.10+8-b1207.12 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 5.10.0-19-amd64
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry:
  ide.balloon.shadow.size=0
  ide.browser.jcef.enabled=false
  debugger.anti.flickering.delay=0
  run.processes.with.pty=TRUE
  ide.intellij.laf.enable.animation=true
  ide.ui.font.force.use.inter.font=true
  ide.text.fractional.metrics=[Auto|Disabled*|Enabled]
  editor.text.fractional.metrics=[Auto|Disabled*|Enabled]
  ide.slow.operations.assertion=false
  codeWithMe.voiceChat.enabled=false
  shared.indexes.download.auto.consent=true
Non-Bundled Plugins:
  dk.cego.gitlab_ci_local_plugin (0.0.5)
  org.moniaga.openapi (1.3.4)
  io.github.stdupanda.plugin.intellij.MyPlugin (1.0.0)
  com.linkkou.plugin.intellij.assistant (5.0.1)
  com.github.y0ung3r.gitglobalhookslocator (0.0.2)
  awesome.console (0.1337.12)
  com.github.bozsadam.tabasclass (1.0.2)
  top.walterInKitchen.gitDiffShort (1.1.23)
  com.mirkoalicastro.gotogit (0.0.3)
  com.github.pppurple.locate-opened-file (1.0.0)
  org.OverEngineer.InlineProblems (0.5.2)
  com.pyfips.intellij.custominspections (2.0.2)
  com.GEN.LastEdited.v1 (1.10.2)
  indent-rainbow.indent-rainbow (2.2.0)
  com.shetline.ligatures-limited (1.0.4)
  GrepConsole (12.25.0-IJ2023.3)
  com.jetbrains.changeReminder (241.14494.150)
  com.vladsch.git-file-case-fixer (1.0.20)
  de.shyim.ideaphpstantoolbox (0.0.7)
  ru.vkurdin.idea.php.lambdafolding (0.3.0)
  com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0)
  com.wbars.php.folding (1.0.3)
  com.github.timo_reymann.composer_dump_autoload_phpstorm_plugin (2.1.1)
  com.funivan.idea.phpClean (2023.12.17)
  com.daveme.intellij.chocolateCakePHP (0.8.3)
  CakeConfigureCompletion (0.1)
  com.github.ekvedaras.classfactoryphpstorm (2.0.4)
  com.funivan.phpstorm.refactoring (0.1.1)
  net.king2500.plugins.PhpAdvancedAutoComplete (1.1.0)
  de.espend.idea.php.toolbox (6.2.0)
  de.espend.idea.php.annotation (10.0.0)
  dev.dohpaz.php-extras (2.2.0)
  net.rentalhost.plugins.php.hammer (0.30.0)
  org.endpointdeps.EndpointDependencies (1.3)
  gr.jchrist.gitextender (0.8.1)
  git-extended-update-index (0.1.3)
  com.virtuslab.git-machete (4.2.0)
  io.nimbly.json.Any2Json (2.19.0)
  com.github.lppedd.idea-return-highlighter (0.8.3)
  com.github.shiraji.findpullrequest (2.0.4)
  org.custompush (2.0.1)
  GitCheckoutFilesFromOtherBranch (0.1.1)
  cn.ryoii.git-extend-untracked (0.1.2)
  zielu.gittoolbox (500.2.3+233)
  mobi.hsz.idea.gitignore (4.5.2)
  org.jetbrains.plugins.docker.gateway (241.14494.189)
Current Desktop: Undefined
arancaytar commented 6 months ago

Just ran into this on PhpStorm 2024.1.1 with EA 5.0.0.0.

PhpStorm 2024.1.1
Build #PS-241.15989.102, built on April 23, 2024
Licensed to Christoph Burschka
Subscription is active until July 31, 2024.
Runtime version: 17.0.10+1-b1207.14 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 16
Registry:
  run.processes.with.pty=TRUE
Non-Bundled Plugins:
  com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0)
  de.espend.idea.php.annotation (10.0.0)
  org.masamotod.idea.Drupal8NamespaceDetector (1.0)
  fr.adrienbrault.idea.symfony2plugin (2023.1.271)
  de.espend.idea.php.drupal (0.6.0)
StyxUA commented 6 months ago

Any progress? It's kind of lame to add @noinspection UnknownInspectionInspection everywhere:

/** @noinspection UnknownInspectionInspection, PhpMultipleClassDeclarationsInspection */
wtfmrpresident commented 2 months ago

We want progress =)

michabbb commented 2 months ago

hey, calm down, it´s only one year old. give them 3 more years... please.....

ea-inspections-team commented 2 months ago

Thank you for reporting @lostfocus and your patience everyone. We are working on the fix right now.

ea-inspections-team commented 2 months ago

Hi everyone, we pushed a fix which improves IDE compatibility and extracting inspections names (filtering out empty values). We could not reproduce the bug and would appreciate feedback once we release the fix (end of September).

michabbb commented 1 month ago

@ea-inspections-team in which version should the fix be included ? thanks

michabbb commented 1 month ago

@ea-inspections-team PING

ea-inspections-team commented 1 month ago

@michabbb, in v2024.2 for EA ultimate and v 5.1.0 for EA Extended.

We are working on fixes for https://github.com/kalessil/phpinspectionsea/issues/1925, and delaying the release. If no solution found today, we will proceed with the releases tomorrow.

michabbb commented 1 month ago

@ea-inspections-team so please don´t close issues if the fix isn´t online, that makes it very hard to find out, if something is really fixed. thanks!

kalessil commented 1 month ago

@ea-inspections-team: reframing the last comment, I'd suggest labeling closed issues with the target release version or looking into https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository.

We have had multiple requests in the past to better relate releases and GitHub issues — I read @michabbb's comment as a similar request.

michabbb commented 1 month ago

just for the record, saw this update today 😊

image

wtfmrpresident commented 1 month ago

u r the best, thanks!