Code reordering: split phpunit inspection in different inspections

kalessil / phpinspectionsea

A Static Code Analyzer for PHP (a PhpStorm/Idea Plugin)

https://plugins.jetbrains.com/plugin/7622?pr=phpStorm

Other

1.44k stars 119 forks source link

Code reordering: split phpunit inspection in different inspections #322

Open rentalhost opened 7 years ago

rentalhost commented 7 years ago

I am reading the phpunit inspection code (at PhpUnitTestsInspector) and it seems be very confuse.

Can we think about split it in different inspections and files? For instance, maybe I like to disable a specific inspection. Currently I should disable all them (with a unique exception case for the assert::same).

Seems too much responsability to a single inspection.

kalessil commented 7 years ago

Will happen, but not this year please. Same for splitting if-strategies.

rentalhost commented 7 years ago

No problem, I am focusing on milestone and last opened issues that seems to be useful for now. Code reordering and refactoring should be done sloooowly.

kalessil commented 7 years ago

^_^, correct =)