search

kalessil / production-dependencies-guard

MIT License
87 stars 2 forks source link

FR: `accept-license:xxx` if `check-license` presented #8

Closed kalessil closed 5 years ago

shochdoerfer commented 5 years ago

Maybe a whitelist makes more sense. Otherwise I have to constantly monitor the used licenses and include the ones in the disallow-license list. Default would be allow anything, once the setting is enabled only licenses that are part of the defined list are allowed.

kalessil commented 5 years ago

@shochdoerfer : sounds great

kalessil commented 5 years ago

Implemented!

ScreamingDev commented 5 years ago

That was faster than I could have a look and I like it! :D But also a bit sad about composer that things are not nested like

"white-list:not this but..."
"white-list": [
  "this",
  "yay",
]
kalessil commented 5 years ago

Yep, json is not allowing to do

{
    "string-setting", /* needs key, and `"setting": "setting"` is silly */
    "array-setting": [ ... ]
}