search

kalgory-com / kalgory-py

Python client library for kalgory
Mozilla Public License 2.0
0 stars 0 forks source link

Publish to pypi #10

Closed ChuWeiChang closed 1 month ago

ChuWeiChang commented 1 month ago

4 #8

I just published the library onto pypitest. The email part currently leads to mine, since I lost track of our collective email account on Cloudflare. This is just a publishing test, and official publish will be made after the email section is set correctly and this PR is approved.

ZhaoTzuHsien commented 1 month ago

After this PR is merged, don't publish the project by hand since I will setup GitHub Actions to automate this. If you're willing to try and learn setting up GitHub actions, please let me know.

ChuWeiChang commented 1 month ago

After this PR is merged, don't publish the project by hand since I will setup GitHub Actions to automate this. If you're willing to try and learn setting up GitHub actions, please let me know.

You can leave this to me.

ChuWeiChang commented 1 month ago

Because the **kwargs wasn't supported in Block.handle(), please update the usage example.

Can you be more specific on this? Since we currently use json array, so handle is called by Block.handle(*arg). I don't quite follow.

ZhaoTzuHsien commented 1 month ago

After this PR is merged, don't publish the project by hand since I will setup GitHub Actions to automate this. If you're willing to try and learn setting up GitHub actions, please let me know.

You can leave this to me.

@ChuWeiChang

Here is the docs for GitHub Actions: https://docs.github.com/en/actions

You can create a new workflow file which is triggered by release published. Whenever the release is published, the workflow will test the code first, and if no error, just publish it to PyPI.

Create a separate issue and PR to handle GitHub Actions.

ZhaoTzuHsien commented 1 month ago

Because the **kwargs wasn't supported in Block.handle(), please update the usage example.

Can you be more specific on this? Since we currently use json array, so handle is called by Block.handle(*arg). I don't quite follow.

Since most programming languages don't support keyword arguments, we use JSON array to describe arguments list. Because of that, *args should be used instead of **kwargs

ChuWeiChang commented 1 month ago

Since most programming languages don't support keyword arguments, we use JSON array to describe arguments list. Because of that, *args should be used instead of **kwargs

Didn't know you were mentioning README.md. It's updated now. As for the github actions, I will ask for re-review after they are set up

ZhaoTzuHsien commented 1 month ago

Since most programming languages don't support keyword arguments, we use JSON array to describe arguments list. Because of that, *args should be used instead of **kwargs

Didn't know you were mentioning README.md. It's updated now. As for the github actions, I will ask for re-review after they are set up

You can send review request and I'll check the publish details. For GitHub Actions, create a new issue and PR.