kaliber-scala / play-s3

S3 module for Play
MIT License
119 stars 49 forks source link

Listing more than 1000 items in a bucket #23

Closed denodaeus closed 10 years ago

denodaeus commented 10 years ago

Is there a way to configure this to list more than 1000 items? Example:

val bucket = S3("my bucket") bucket list "foo/" // only returns a max of 1000 items

I know this is an amazon limitation of returning 1000 items per request. I looked at the source in S3.scala and didn't see any special logic handling the case of having more than 1000 items. You have to keep track of this by putting a marker header in the HTTP to tell Amazon where you left off.

EECOLOR commented 10 years ago

Hmm, I have probably missed that (or amazon added it). I currently have very little time. If you create a test case and (if you feel up to it) a change to the library it would help tremendously. Just fork the repository and submit a pull request.

As soon as I have some time on my hands I will address this issue.

In order to run the tests you need an application.conf file in the test/conf folder containing a valid aws.accessKeyId and aws.secretKey.

denodaeus commented 10 years ago

Yep, I've already forked and I'm working on a change now, so hopefully I'll get it belted out in a couple of days. Right now it's just feeling out how to do with async/futures in scala idiomatically -- new territory :)

Thanks again for your work.