kaliber-scala / play-s3

S3 module for Play

MIT License

119 stars 49 forks source link

Updated to play 2.6 and Scala 2.12 #80

Closed n0tel closed 7 years ago

n0tel commented 7 years ago

79 #74 Tests passed

n0tel commented 7 years ago

I think we can extend AwsRequestHolder from AhcWSRequest instead of WSRequest. Because with play2.6 many realization of method was removed from WSRequest and added to AhcWSRequest. (like get, put, post etc.)

But for now i just implements it inside AwsRequestHolder. What you think?

EECOLOR commented 7 years ago

@Hayena @jorkzijlstra Does one of you have time to integrate this?

EECOLOR commented 7 years ago

Oh and @n0tel thank you for the effort to create a pull request!

lucianenache commented 7 years ago

Hi, are there any plans on merging the PR ? If necessary I could help :)

EECOLOR commented 7 years ago

Hey @lucianenache,

it seems that @Hayena and @jorkzijlstra are on vacation or busy themselves. I could make you a contributor of the repository so you can do the merge and release. I myself do not have time to spend on this project at the moment.

A few things that are important (from the top of my head):

Make sure a branch is created for the previous version (see other branches)
Versioning, the version should go up semantically (see other releases for new play versions)
The tests should be run and double-checked
Code should be consistent with the rest of the library (no changes in conventions AND functionality)

If you think you can do it let me know and I'll add you as a contributor.

lucianenache commented 7 years ago

Hi @EECOLOR, it would be nice to be able to maintain this project since it provides a pure implementation for s3 and I am already using it in a couple of projects. Therefore given the guidelines provided earlier I can help with maintaining it and keeping it updated.

EECOLOR commented 7 years ago

@lucianenache that's great! I've added you as a collaborator. Let me know if you have questions.