search

kaliber5 / ember-fastboot-addon-tests

Addon testing support for Fastboot compatibility
MIT License
25 stars 9 forks source link

Include package in installPackages option #12

Closed c410-f3r closed 7 years ago

c410-f3r commented 7 years ago

I am having a hard time trying to include the ember-concurrency package into the fastboot carousel test of ember-bootstrap.

setupTest('carousel', {
  installPackages: {
    'ember-concurrency': '0.8.7'
  }
});

The console output of ember fastboot:serve shows that the package could not be found. ember fastboot:test fails with Error: From should be a file or directory and changing the setupTest name to fastboot also fails with AssertionError (element is not rendered). Tried several strategies with no success, am I doing something wrong here?

simonihmig commented 7 years ago

@c410-f3r I am not sure about this error, would have to investigate. But as this is related to your PR for ember-bootstrap, I am wondering why you would need to install ember-concurrency. It should be specified as a dependency (not devDependency) of ember-bootstrap, so no need to manually install it!?

c410-f3r commented 7 years ago

You are right, it is not an ember-fastboot-addon-tests problem. Sorry for the lack of attention.

simonihmig commented 7 years ago

No problem at all!