kaliber5 / k5-ember-boilerplate

MIT License
0 stars 0 forks source link

Refactor to *App types #118

Open lolmaus opened 3 years ago

lolmaus commented 3 years ago

Current usage:

import { ConfigurationState as BaseCofigurationState } from '@kaliber5/foo';

export interface ConfigurationState extends BaseConfigurationState;

This is problematic because when I try to use ConfigurationState, IDE would suggest the base one from the addon, and there is confusion.

Not renaming ConfigurationState resolves the confusion:

import { ConfigurationState } from '@kaliber5/foo';

export interface ConfigurationStateApp extends BaseConfigurationState;

Note: I suggest that we use App as suffix rather than prefix because it easier to see intention: Foo-something, Bar-something is more visible than App-something, App-somethings.