search

kaliber5 / k5-ember-boilerplate

MIT License
0 stars 0 forks source link

Add all `types/@ember__*` packages explicitly #146

Open lolmaus opened 3 years ago

lolmaus commented 3 years ago

The @types/ember package contains them, but in order for automatic imports to work in VS Code, individual types/@ember__* packages must be explicitly listed in package.json.

https://www.typescriptlang.org/dt/search?search=@typesember

simonihmig commented 3 years ago

As mentioned in the other PR, I am a bit worried having to do this everywhere. Do you have any other confirmations that this is really required for VSCode? (SO, Github issue etc.)

Maybe this gets fixed in VSCode itself eventually?

lolmaus commented 3 years ago

As mentioned in the other PR, I am a bit worried having to do this everywhere

I don't see an issue here. The boilerplate addon will do it automatically.

Do you have any other confirmations that this is really required for VSCode? (SO, Github issue etc.)

Nope.

Maybe this gets fixed in VSCode itself eventually?

I can try starting an issue. 🤷‍♂️

simonihmig commented 3 years ago

I don't see an issue here. The boilerplate addon will do it automatically.

But what about future updates? Say @types/ember introduces a new types/@ember__foo package as a dependency: