search

kaliberjs / build

Zero configuration, modern, opinionated build tools
https://kaliberjs.github.io/build/
MIT License
10 stars 3 forks source link

Stylelint message contains a mistake #203

Open JoostKiens opened 4 years ago

JoostKiens commented 4 years ago

I have the following warning from stylelint plugin: kaliber/parent-child-policy.

missing `display: flex;`
`order` can only be used when the containing root rule has `display: flex;` - add `display: flex;` to the containing root rule or, if this is caused by a media query that overrides `display: flex;`, use `flex: unset`

I believe flex: unset unsets the flex property, not the order property. We'll want to change this to:

order can only be used when the containing root rule has display: flex; - add display: flex; to the containing root rule or, if this is caused by a media query that overrides display: flex;, use order: unset

EECOLOR commented 4 years ago

I think it's this line: https://github.com/kaliberjs/build/blob/master/library/stylelint-plugins/rules/parent-child-policy/index.js#L24