search

kaliiiiiiiiii / Selenium-Driverless

undetected Selenium without usage of chromedriver
https://kaliiiiiiiiii.github.io/Selenium-Driverless/
Other
545 stars 66 forks source link

Optimize binary location retrieval and handling #219

Closed ghost closed 5 months ago

ghost commented 5 months ago

  1. Modified the Options class in src/selenium_driverless/types/options.py to postpone the execution of find_chrome_executable() until binary_location is accessed for the first time, unless it has been explicitly set earlier. This adjustment aims to eliminate unneeded file system checks.

  2. Updated the find_chrome_executable() function in src/selenium_driverless/utils/utils.py to include validations ensuring that PATH is not None before processing it. This enhancement helps avert possible AttributeError on POSIX systems where PATH might be unset.

kaliiiiiiiiii commented 5 months ago

suppose that's gonna fix https://github.com/kaliiiiiiiiii/Selenium-Driverless/issues/215 , thanks!

Will have a look at it & merge after. Might make it raise some exception when chrome hasn't been found on startup