search

kaliiiiiiiiii / Selenium-Profiles

undetected Selenium using chromedriver and emulation / device profiles
Other
273 stars 29 forks source link

Add the possibility to add custom path to driver object #21

Closed Bolini4 closed 1 year ago

Bolini4 commented 1 year ago

I just edited your code to do this : driver.py

line 20 :     def __init__(self, driverPath= None):
line 30 :         self.driverPath = driverPath
line 87 :             self.driver = webdriver.Chrome(options=self.options, executable_path=self.driverPath)`  # start selenium webdriver

I am not very good with github and python but this feature would help me a lot !

EDIT: improved formatting and grammar

kaliiiiiiiiii commented 1 year ago

Sure, I absolutely see the point of this. I'm quite busy, but I'll implement it and at the some time fix some bugs

kaliiiiiiiiii commented 1 year ago

Implemented with https://github.com/kaliiiiiiiiii/Selenium-Profiles/commit/b77151a0b4cbe2c35db7f44d0c8c01cd5712e03d example: 

driver = mydriver.start(profile, uc_driver=False, 
    chrome_binary="C:/Program Files/Google/Chrome/Application/chrome.exe",
    executable_path= "chromedriver.exe")

@Bolini4 Feel free to install the new version and test with and without uc_driver , then close this issue if it's resolved and maybe give me a star:)

Bolini4 commented 1 year ago

This solution worked well ! I'm happy to work with your solution !