search

kalilistic / xivplugins

All the dalamud plugins and repos that can be found on github and a few more. Formally, neat-plugins-plus.
https://xivplugins.com
MIT License
20 stars 1 forks source link

API returns incorrect url for xivdev's Penumbra repo #7

Closed Zebouski closed 2 years ago

Zebouski commented 2 years ago

https://github.com/xivdev/Penumbra 's readme says the repo URL to add to dalmud, should be the URL ending in repo.json, but this API is returning a url ending in base_repo.json 

 curl -X 'GET' \
                              'https://api.kalilistic.io/dalamud/repos' \
                            'https://api.kalilistic.io/dalamud/repos''accept: application/json' \
                            | jq | grep "xivdev"
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 28710  100 28710    0     0  24944      0  0:00:01  0:00:01 --:--:-- 24965
curl: (3) URL using bad/illegal format or missing URL
    "owner": "xivdev",
    "fullName": "xivdev/Penumbra",
    "pluginMasterUrl": "https://raw.githubusercontent.com/xivdev/Penumbra/master/base_repo.json"

I noticed this breaking the installation of penumbra via https://github.com/UnknownX7/DalamudRepoBrowser, which is said to use this API

kalilistic commented 2 years ago

Will fix this and a few other bugs today. Thanks for letting me know.

kalilistic commented 2 years ago

I made a quick fix of changing the penumbra master url to https://raw.githubusercontent.com/xivdev/Penumbra/master/repo.json.