search

kalilistic / xivplugins

All the dalamud plugins and repos that can be found on github and a few more. Formally, neat-plugins-plus.
https://xivplugins.com
MIT License
20 stars 1 forks source link

Last updataed some problem #8

Closed tssailzz8 closed 2 years ago

tssailzz8 commented 2 years ago

image image it not true

kalilistic commented 2 years ago

This is due to the github api updated_at field can be updated by other changes to the repository like changing a description or setting and not just commits.

https://api.github.com/repos/daemitus/YesAlready "updated_at": "2022-02-28T08:27:10Z",

The date/time you highlighted is the last commit which is a separate endpoint. I tried using this originally but it's a separate endpoint which is a pain due to github's severe rate limiting.

Although, looking now.... at least in this case the pushed_at matches the last commit. I'll need to compare some other repos but I wonder if I could use this instead of updated_at. "pushed_at": "2022-01-29T03:49:32Z",

kalilistic commented 2 years ago

I switched to pushed_at... let me know what you think. I see one or two that are a little odd but seems better. I'll consider other ways to use the commit endpoint.

tssailzz8 commented 2 years ago

I just want to know who recently updated the code

kalilistic commented 2 years ago

bah, thanks github. I'll look at this more today.

kalilistic commented 2 years ago

Okay, seems to be working now and matches the last commit. Let me know if looks good to you.

kalilistic commented 2 years ago

Just noticed a few non-github plugins aren't updating their date correctly. Will look at those too. Fixed.