kalinjul / kotlin-multiplatform-oidc

Kotlin Multiplatform OpenIDConnect implementation for Android/iOS

https://kalinjul.github.io/kotlin-multiplatform-oidc/

Apache License 2.0

40 stars 15 forks source link

Added invalid grant to the ErrorRespons Error enum #60

Closed nmrsmn closed 2 months ago

nmrsmn commented 2 months ago

Hi, thanks for getting into this project!

Checklist for your PR:

[x] Check if there's any open issue
[x] Please file your request against the develop branch

Description of your changes

I've added the invalid_grant error code to the enum of possible errors as this is returned by keycloak.

How has this been tested?

Being tested locally using a build of my app

Is this a (API-) breaking change?

kalinjul commented 2 months ago

Hi, could you also add unsupported_grant_type and add the link for the token error response to the comment? https://datatracker.ietf.org/doc/html/rfc6749#section-5.2

Thanks for fixing this!

nmrsmn commented 2 months ago

@kalinjul Is there something I can do to make the build succeed, did I do something wrong? Also what is the process to get something like this PR to production/released? I'm kinda stuck going further with my implementation without this

kalinjul commented 2 months ago

@nmrsmn No everything is fine, thanks. I will merge this into develop and you can try the next snapshot build (add maven("https://s01.oss.sonatype.org/content/repositories/snapshots/") to your repositories). I will then release a new stable version soon-ish.