search

kalisio / kano

Map and weather forecast data explorer in 2D/3D
https://kalisio.github.io/kano/
MIT License
24 stars 7 forks source link

Switching between forecast models can break the timeline #24

Closed claustres closed 5 years ago

claustres commented 5 years ago

On the deployed version https://kano.irsn.kalisio.xyz/#/home/map?south=29.15216128331894&west=-60.77636718750001&north=58.790978406215565&east=23.598632812500004 select a date at least 3 days after current time, then switch the forecast model to AROME, which has a small range, the timeline overflow the screen.

leob commented 5 years ago

I'll have a look at this.

leob commented 5 years ago

I was now finally able to reproduce this issue. It looks like the "overflow" problem is related to the way I calculate the size of the "intervals", now looking at this.

leob commented 5 years ago

I'm able to reproduce this, looking at it ... (part of the) problem seem to be that changing the "value" prop on the component isn't reflected internally in the 'data', trying to work around this with a watcher ...

leob commented 5 years ago

This should be fixed now, I've pushed a corrected version of MapActivity.vue (git commit 8bc8a47 in the kano repo).

leob commented 5 years ago

Closing this now