search

kalismeras61 / flutter_page_transition

This is Flutter Page Transition Package
BSD 2-Clause "Simplified" License
475 stars 57 forks source link

Implemented leftToRightJoined & rightToLeftJoined #38

Closed benwinding closed 3 years ago

benwinding commented 3 years ago

Closes #37

Hi @kalismeras61, This is my implementation, without changing your API. The only thing to note, is that types leftToRightJoined and rightToLeftJoined require another argument childCurrent, which is the current page of the transition. I've put a assert() warning to help with this.

Let me know what you think! Cheers, Ben

kalismeras61 commented 3 years ago

Thanks for the PR , just one thing i added comment inline.

jimmyff commented 3 years ago

hey @benwinding is there a way I could get hold of the current page widget (for childCurrent) from generateRoute(RouteSettings) ?

If so it would be great to maybe add that to the example in the readme for the package.